Wouldn't it make more sense for the diamond and heart pips to be red and the spade and club pips to be white?
It depends on how you look at it. The "black suits" are the darker color, the "red suits" are the lighter color, just as you'd expect from a standard deck. Beyond that, ask Si Scott!
It's different, yes, and it's a change of pace - but I like it. To be less confusing regarding red/white, the "black suit" indices are actually in gold, so in a spread you'll only see gold (dark suits) and white (light suits). Of all the color schemes I've seen thus far, particularly ones not using a shade of black for black and a shade of red for red, this one's not bad at all - and trust me, I've seen far worse!
(BTW: ever want to burn someone's eyes out of their skull? Pick up "The Yellow Deck" from Magic Makers. It's so freakin' bright, it sets off Geiger counters! I think I used my pack once. Just once. I still have the corneal burns to show for it!)